mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Review Request 58967: Set the working directory to parent task's for DEBUG containers.
Date Wed, 03 May 2017 16:46:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58967/
-----------------------------------------------------------

Review request for mesos, Gastón Kleiman, Jie Yu, and Vinod Kone.


Bugs: MESOS-7433
    https://issues.apache.org/jira/browse/MESOS-7433


Repository: mesos


Description
-------

A DEBUG container's working directory should be set to the parent
task's working directory. For the command executor case, even if
the task itself has a root filesystem, the executor container still
uses the host filesystem, hence
`ContainerLaunchInfo.working_directory`, pointing to the executor's
working directory in the host filesystem, may be different from the
task's working directory in the root filesystem.


Diffs
-----

  include/mesos/slave/containerizer.proto c30b1fc659ee9b3cd343899638ced6408d8b51a2 
  src/slave/containerizer/mesos/containerizer.cpp b58baed64480e22f640a4852537f85922ed382ae



Diff: https://reviews.apache.org/r/58967/diff/1/


Testing
-------

make check on Mac OS and Fedora 24


Thanks,

Alexander Rukletsov


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message