mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 59018: Supported Image::Secret in docker URI fetcher plugin.
Date Wed, 10 May 2017 15:54:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59018/#review174490
-----------------------------------------------------------



Bad patch!

Reviews applied: [59018, 59017, 59016, 59141, 59015, 59014, 59013, 59012, 59011, 59010, 59001,
59000, 58999, 58760, 58759, 58925, 58924, 58923]

Failed command: python support/apply-reviews.py -n -r 59018

Error:
2017-05-10 15:54:22 URL:https://reviews.apache.org/r/59018/diff/raw/ [8186/8186] -> "59018.patch"
[1]
error: patch failed: src/uri/fetchers/docker.cpp:324
error: src/uri/fetchers/docker.cpp: patch does not apply

Full log: https://builds.apache.org/job/Mesos-Reviewbot/18022/console

- Mesos Reviewbot


On May 10, 2017, 12:48 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59018/
> -----------------------------------------------------------
> 
> (Updated May 10, 2017, 12:48 p.m.)
> 
> 
> Review request for mesos, Adam B, Chun-Hung Hsiao, Jie Yu, Kapil Arya, Till Toenshoff,
and Vinod Kone.
> 
> 
> Bugs: MESOS-7088
>     https://issues.apache.org/jira/browse/MESOS-7088
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Supported Image::Secret in docker URI fetcher plugin.
> 
> 
> Diffs
> -----
> 
>   src/uri/fetchers/docker.cpp 44169bf5f22f0ffd9fad7bb3b8f7d2a4989c6415 
> 
> 
> Diff: https://reviews.apache.org/r/59018/diff/2/
> 
> 
> Testing
> -------
> 
> make check
> 
> Manually tested using mesos-execute with task group. Verified that pulling separate private
image from different registries using different image secrets works correctly.
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message