mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jiang Yan Xu <...@jxu.me>
Subject Re: Review Request 59154: Added workaround to unbreak the build with glibc <= 2.12.
Date Wed, 10 May 2017 19:06:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59154/#review174530
-----------------------------------------------------------


Ship it!




Ship It!

- Jiang Yan Xu


On May 10, 2017, 11:59 a.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59154/
> -----------------------------------------------------------
> 
> (Updated May 10, 2017, 11:59 a.m.)
> 
> 
> Review request for mesos, James Peach, Michael Park, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-7378
>     https://issues.apache.org/jira/browse/MESOS-7378
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> In old versions of glibc, the <sys/sysmacros.h> header must be enclosed
> in an `extern "C" { ... }` block. This prevents Mesos from linking on
> CentOS 6.9 and likely other platforms from the same timeframe.
> 
> In more recent versions of glibc, the `extern "C" { ... }` linkage
> declaration is not necessary (because the header file specifies this
> itself). In this situation, there will now be two linkage declarations,
> but that is fine: the inner-most linkage declaration takes precedence.
> 
> 
> Diffs
> -----
> 
>   src/linux/fs.cpp 944509f357d2e3f52365a8359738cf170dfcc563 
>   src/slave/containerizer/mesos/isolators/cgroups/subsystems/devices.cpp e995ff450d710d847eab827b7021f454f475fcef

>   src/slave/containerizer/mesos/isolators/gpu/isolator.cpp 3fd14951fd93a1a6230ccd5c446fdf4ba3915878

>   src/tests/containerizer/fs_tests.cpp 0fa9451553990deadb2693494835554c5c34994f 
> 
> 
> Diff: https://reviews.apache.org/r/59154/diff/1/
> 
> 
> Testing
> -------
> 
> `make check` on OSX, CentOS 6.9 (old glibc), and recent Arch Linux (new glibc).
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message