mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anindya Sinha <anindya_si...@apple.com>
Subject Re: Review Request 58487: Fix allocation quantities when shared resources are removed.
Date Thu, 11 May 2017 18:13:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58487/
-----------------------------------------------------------

(Updated May 11, 2017, 6:13 p.m.)


Review request for mesos, James Peach and Jiang Yan Xu.


Bugs: MESOS-7308
    https://issues.apache.org/jira/browse/MESOS-7308


Repository: mesos


Description
-------

When shared resources are removed from the `allocations` in the sorter,
we remove the scalar quantity only when the shared resource is actually
removed (i.e. shared count goes down to 0). Similarly, we increase the
scalar quantity only when this is a new shared resource that is being
added to the `allocations`.


Diffs
-----

  src/master/allocator/sorter/drf/sorter.hpp fee58d6d1f08163e2a06a4a20c891fe535c3dcff 


Diff: https://reviews.apache.org/r/58487/diff/3/


Testing
-------

Tests passed.


Thanks,

Anindya Sinha


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message