mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Coffler <j...@taltos.com>
Subject Review Request 59201: Ported the IPNetwork::fromLinkDevice to the Windows Platform.
Date Thu, 11 May 2017 20:14:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59201/
-----------------------------------------------------------

Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and Li Li.


Bugs: MESOS-5938
    https://issues.apache.org/jira/browse/MESOS-5938


Repository: mesos


Description
-------

Note that, on Windows, IPNetwork::fromLinkDevice takes a MAC address
rather than a network name. See associated chagnes to net::links for
an explanation of why this is the case.


Diffs
-----

  3rdparty/stout/include/stout/ip.hpp ad2bd922158eecd12b51b272d2a003b8ec8d3550 
  3rdparty/stout/include/stout/posix/ip.hpp PRE-CREATION 
  3rdparty/stout/include/stout/windows/ip.hpp PRE-CREATION 


Diff: https://reviews.apache.org/r/59201/diff/1/


Testing
-------

See final commit for tests performed.


Thanks,

Jeff Coffler


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message