mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Adam B <a...@mesosphere.io>
Subject Re: Review Request 59198: Documented that Mesos 1.3.0, 1.2.1 don't allow old agents to register.
Date Thu, 11 May 2017 20:25:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59198/#review174722
-----------------------------------------------------------



Couple more nits, then we can ship-it


CHANGELOG
Line 52 (original), 52 (patched)
<https://reviews.apache.org/r/59198/#comment247939>

    Still mixing `> 1.0` and `pre-1.0`, so either `s/pre-1.0/0.x/g` or `s/pre-1.0/<
1.0/` or `s/> 1.0/1.1+/`



docs/upgrades.md
Line 278 (original), 278 (patched)
<https://reviews.apache.org/r/59198/#comment247940>

    Ditto on `> 1.0` and `pre-1.0`.



docs/upgrades.md
Lines 50 (patched)
<https://reviews.apache.org/r/59198/#comment247941>

    Should we add the same thing to 1.2.x (with a special note that it only applies to `1.2.1+`)?


- Adam B


On May 11, 2017, 12:47 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59198/
> -----------------------------------------------------------
> 
> (Updated May 11, 2017, 12:47 p.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Documented that Mesos 1.3.0, 1.2.1 don't allow old agents to register.
> 
> 
> Diffs
> -----
> 
>   CHANGELOG 31c21e9a69a6e11429b58a7eddecf7746a284530 
>   docs/upgrades.md 74e74642b411eefb737d575b89a1f206cae62b46 
> 
> 
> Diff: https://reviews.apache.org/r/59198/diff/3/
> 
> 
> Testing
> -------
> 
> Visual inspection, no functional change.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message