mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Coffler <j...@taltos.com>
Subject Re: Review Request 59200: Ported the net::links routine to Windows platform.
Date Thu, 11 May 2017 20:41:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59200/#review174724
-----------------------------------------------------------




3rdparty/stout/include/stout/windows/net.hpp
Lines 62 (patched)
<https://reviews.apache.org/r/59200/#comment247942>

    Oops, I added this comment at the last minute, neglecting to notice that I had the comment
at line 40-41 on this same issue.
    
    I'll post an update to this commit to get rid of this.


- Jeff Coffler


On May 11, 2017, 8:13 p.m., Jeff Coffler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59200/
> -----------------------------------------------------------
> 
> (Updated May 11, 2017, 8:13 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and Li Li.
> 
> 
> Bugs: MESOS-5938
>     https://issues.apache.org/jira/browse/MESOS-5938
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Note that, rather than returning an interface name, the Windows
> version will return the MAC address. The actual interface name,
> on Windows, is a GUID (since there can be multiple wireless
> interfaces, for example). However, it's not possible to get the
> MAC access from the command line.
> 
> As a result, the MAC address of the interface (also unique) is
> used to uniquely identify a particular interface on the system.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/net.hpp b7cef53d3df8688f88211d7107927b7c8ccaed7f 
>   3rdparty/stout/include/stout/posix/net.hpp 39b89828d350d83bf1d4b0badcd3e63eb9d1a630

>   3rdparty/stout/include/stout/windows/net.hpp 1bed115cb848332bf9c31e455b2d001c173face9

> 
> 
> Diff: https://reviews.apache.org/r/59200/diff/1/
> 
> 
> Testing
> -------
> 
> See final commit for tests performed.
> 
> 
> Thanks,
> 
> Jeff Coffler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message