mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Coffler <j...@taltos.com>
Subject Review Request 59297: Fix autotools to include ip.hpp & mac.hpp in stout/{posix|windows}.
Date Mon, 15 May 2017 22:42:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59297/
-----------------------------------------------------------

Review request for mesos.


Repository: mesos


Description
-------

Required since autotools includes .hpp files.


Diffs
-----

  3rdparty/stout/include/Makefile.am ea4341b2dccc3d73b9d347d29486ab4c8ff42217 


Diff: https://reviews.apache.org/r/59297/diff/1/


Testing
-------

This was an autotools-specific problem, I didn't catch this right away since my tests didn't
build with autotools.

Now they do:

1. Autotools built successfully (cmake -j6 distcheck), and
2. Cmake built successfully (cmake -j6 check).

I'll be careful to check autotools in the future, particularly when adding files.

Note that a few lines had line continution not lining up. I resolved those for consistency
with the rest of the file.


Thanks,

Jeff Coffler


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message