mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jiang Yan Xu <...@jxu.me>
Subject Review Request 59289: Refactored log Metrics into separate files.
Date Mon, 15 May 2017 22:46:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59289/
-----------------------------------------------------------

Review request for mesos, Anindya Sinha and Jie Yu.


Bugs: MESOS-7507
    https://issues.apache.org/jira/browse/MESOS-7507


Repository: mesos


Description
-------

A separate cpp file is more appropriate as we add more metrics and 
make the struct more complex.

No functional change.


Diffs
-----

  src/CMakeLists.txt eef718d95b5d8e051a5094369dc9b4532bc307ff 
  src/Makefile.am 6bb81fd49b4564a0afa993b2cef6baa9d370ee7a 
  src/log/log.hpp a600025f4ca38e3fad0f64f48b007138da8e22d4 
  src/log/log.cpp 2301eef564f2a42958c6c2c8eef0cc4b2fd76353 
  src/log/metrics.hpp PRE-CREATION 
  src/log/metrics.cpp PRE-CREATION 


Diff: https://reviews.apache.org/r/59289/diff/1/


Testing
-------

make check.


Thanks,

Jiang Yan Xu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message