mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Re: Review Request 58349: Updated GMock/GTest to version 1.8.0.
Date Tue, 16 May 2017 23:35:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58349/#review175174
-----------------------------------------------------------


Ship it!




There are more `tr1` references in `sorter_tests.cpp` -- can you fix these?

See also earlier comments on updating gmock references in `LICENSE` and `entrypoint.sh`.

- Neil Conway


On May 15, 2017, 12:05 p.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58349/
> -----------------------------------------------------------
> 
> (Updated May 15, 2017, 12:05 p.m.)
> 
> 
> Review request for mesos, Neil Conway and Till Toenshoff.
> 
> 
> Bugs: MESOS-7364
>     https://issues.apache.org/jira/browse/MESOS-7364
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This will fix various issues that occured with version 1.7.0.
> As GTest is now using 'std::tuple' instead of 'std::tr1::tuple', some
> test cases have been updated accordingly.
> 
> 
> Diffs
> -----
> 
>   3rdparty/CMakeLists.txt cb118f6c454c3bb36990e292a31703e4a3f99483 
>   3rdparty/Makefile.am 61d832b2d83cdeaf95341c062e8493ab72d0724e 
>   3rdparty/cmake/Versions.cmake 728f88fe57aef4dd7be1d40c7c0227ad2db5015e 
>   3rdparty/gmock-1.7.0.tar.gz 09f5ea3ce95fab34c505367ae04965e01c8bb30d 
>   3rdparty/googletest-release-1.8.0.tar.gz PRE-CREATION 
>   3rdparty/versions.am b8144702adca9dd41199f69cb6fb0c0c4b490dbd 
>   configure.ac fe5b20b53ea007dd8f2e3349e9904f6c4f43a14b 
>   src/Makefile.am 6bb81fd49b4564a0afa993b2cef6baa9d370ee7a 
>   src/tests/cmake/MesosTestsConfigure.cmake 62e274114e7ab062e037ef194781828146e15fed

>   src/tests/fetcher_cache_tests.cpp 3bd63ed0a66493829a82c542ad05ebe0f7828d1a 
>   src/tests/hierarchical_allocator_tests.cpp 08180b9975869de328f0c095dd3cddf0c84fbecf

>   src/tests/scheduler_tests.cpp 0f5d9ada6eb880379baf5f106fd2d5b12e9738db 
>   src/tests/sorter_tests.cpp 8e7ff79a0401ed721429752be4b010727b875e11 
> 
> 
> Diff: https://reviews.apache.org/r/58349/diff/4/
> 
> 
> Testing
> -------
> 
> Tested in https://reviews.apache.org/r/58351/
> 
> Don't commit without 58350 and 58351.
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message