mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jiang Yan Xu <...@jxu.me>
Subject Re: Review Request 59434: Added a few master log lines.
Date Mon, 22 May 2017 20:56:25 GMT


> On May 22, 2017, 9:42 a.m., James Peach wrote:
> > src/master/master.cpp
> > Lines 5615 (patched)
> > <https://reviews.apache.org/r/59434/diff/1/?file=1726504#file1726504line5615>
> >
> >     This basically duplicates the INFO message below. Why do we need both?

I frankly did it for consistency between this and the re-register case.


> On May 22, 2017, 9:42 a.m., James Peach wrote:
> > src/master/master.cpp
> > Line 5946 (original), 5955 (patched)
> > <https://reviews.apache.org/r/59434/diff/1/?file=1726504#file1726504line5955>
> >
> >     This basically duplicates the INFO message on line 6127. Why do we need both?

I guess you mean 6137:

```
  LOG(INFO) << "Re-registered agent " << *slave
            << " with " << slave->info.resources();
```

A lot is done between these lines (building the recovered tasks) and this indirectly gives
us the time that is spent on these lines.

This information is normally not informative enough to warrant a LOG(INFO) so that's why I
chose VLOG(1).


- Jiang Yan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59434/#review175652
-----------------------------------------------------------


On May 21, 2017, 10:38 p.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59434/
> -----------------------------------------------------------
> 
> (Updated May 21, 2017, 10:38 p.m.)
> 
> 
> Review request for mesos and James Peach.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> - On the agent (re)-registration code paths.
> - Could be helpful for triaging performance issues.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp 02affe2d6dc76ef91363df04d8d8cbed3beaf34f 
> 
> 
> Diff: https://reviews.apache.org/r/59434/diff/1/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message