mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Aaron Wood via Review Board <nore...@reviews.apache.org>
Subject Re: Review Request 59454: Adjust tests to account for GCC 7.1 fix in bytes.hpp.
Date Wed, 24 May 2017 17:53:44 GMT


> On May 23, 2017, 10:50 p.m., James Peach wrote:
> > src/tests/role_tests.cpp
> > Line 909 (original), 909 (patched)
> > <https://reviews.apache.org/r/59454/diff/2/?file=1726951#file1726951line909>
> >
> >     I think this should be:
> >     ```
> >     constexpr Bytes DISK_SIZE = Megabytes(1);
> >     ```

Thanks for the catch.


- Aaron


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59454/#review175875
-----------------------------------------------------------


On May 24, 2017, 5:53 p.m., Aaron Wood wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59454/
> -----------------------------------------------------------
> 
> (Updated May 24, 2017, 5:53 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, James Peach, Michael Park, and Neil Conway.
> 
> 
> Bugs: MESOS-7520
>     https://issues.apache.org/jira/browse/MESOS-7520
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This fixes tests that uses the old inheritance types from `bytes.hpp`.
> 
> 
> Diffs
> -----
> 
>   src/tests/persistent_volume_tests.cpp ef0085316 
>   src/tests/role_tests.cpp 03b6f7bd6 
> 
> 
> Diff: https://reviews.apache.org/r/59454/diff/3/
> 
> 
> Testing
> -------
> 
> `./bootstrap && mkdir build && cd build && ../configure --disable-python
--disable-java --disable-optimize --disable-hardening &&  make check -j$(nproc)`
> 
> 
> Thanks,
> 
> Aaron Wood
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message