mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 59556: Windows: Updated build documentation.
Date Thu, 25 May 2017 21:20:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59556/#review176128
-----------------------------------------------------------


Ship it!




I can make some of these tweaks before committing.


docs/windows.md
Lines 10-13 (original), 10-11 (patched)
<https://reviews.apache.org/r/59556/#comment249459>

    These double-newlines are part of the markdown style guidelines we use in Mesos docs.



docs/windows.md
Lines 39 (patched)
<https://reviews.apache.org/r/59556/#comment249460>

    s/not/note/



docs/windows.md
Lines 68-69 (original), 77-78 (patched)
<https://reviews.apache.org/r/59556/#comment249461>

    This can be updated.  The master can be run in a non-HA setup now.



docs/windows.md
Lines 79-82 (original), 82-85 (patched)
<https://reviews.apache.org/r/59556/#comment249462>

    Docker containerizer works now (sorta).  So we can remove this point.


- Joseph Wu


On May 24, 2017, 4:38 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59556/
> -----------------------------------------------------------
> 
> (Updated May 24, 2017, 4:38 p.m.)
> 
> 
> Review request for mesos, Jeff Coffler, John Kordich, Joseph Wu, and Li Li.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Windows: Updated build documentation.
> 
> 
> Diffs
> -----
> 
>   docs/windows.md b070c64af508479996d6ef6c3b198c433b5dc600 
> 
> 
> Diff: https://reviews.apache.org/r/59556/diff/1/
> 
> 
> Testing
> -------
> 
> It's build docs, please review. It's somewhat better at least.
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message