mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 59680: Added the 'LocalResourceProvider' structure.
Date Thu, 01 Jun 2017 15:38:44 GMT


> On June 1, 2017, 12:02 a.m., Jie Yu wrote:
> > src/master/master.hpp
> > Lines 291 (patched)
> > <https://reviews.apache.org/r/59680/diff/1/?file=1735330#file1735330line291>
> >
> >     Why both `LocalResourceProvider` and `ResourceProvider`? I'd prefer we don't
have `LocalResourceProvider` top level, and rely on some field in `ResourceProvider` to tell
> 
> Jan Schlicht wrote:
>     I'd prefer to keep those things separate. I don't like the idea of an agent having
a `ResourceProvider` member that isn't a local resource provider only by not having a certain
field not set. Separating resource handling from agent and local resource provider specific
details using composition is IMO the best way to easily add things later that would only affect
local resource provider. Also `ResourceProvider` could be reused for external resource providers.
I feel that adding more fields there to distinguish a local from an external resource provider
would complicate things.

> the best way to easily add things later that would only affect local resource provider

Can you elaborate what are those things?

> Also ResourceProvider could be reused for external resource providers. I feel that adding
more fields there to distinguish a local from an external resource provider would complicate
things.

I think one of the goal IMO is to NOT distinguish local vs. external if possible, and we should
do everything to minimize the difference between a local and external RP in the master.


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59680/#review176557
-----------------------------------------------------------


On May 31, 2017, 12:43 p.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59680/
> -----------------------------------------------------------
> 
> (Updated May 31, 2017, 12:43 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jie Yu.
> 
> 
> Bugs: MESOS-7592
>     https://issues.apache.org/jira/browse/MESOS-7592
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> A local resource provider is a resource provider that is associated
> with an agent. Hence its lifetime is also tied to the lifetime of an
> agent. The 'LocalResourceProvider' structure stores the ID of the
> associated agent as well as the UUID that is used for registration.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp 89d0790fd5fea59e74276f462581fe0073594732 
>   src/master/master.cpp 14007e08f509446005423e223d5dd76a70744e27 
> 
> 
> Diff: https://reviews.apache.org/r/59680/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message