mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 58951: Made reservation endpoints tests independent from allocator.
Date Tue, 06 Jun 2017 12:38:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58951/
-----------------------------------------------------------

(Updated June 6, 2017, 2:38 p.m.)


Review request for mesos, Alexander Rukletsov and Benjamin Mahler.


Changes
-------

Addressed comments from alexr.


Bugs: MESOS-7388
    https://issues.apache.org/jira/browse/MESOS-7388


Repository: mesos


Description
-------

The tests in the case often require an agent ID. To obtain the ID they
were using a mock allocator to grab agent ID, but not other operations
with the allocator were performed.

Instead we now just capture the SlaveRegisteredMessage in order to
learn an agent's ID.


Diffs (updated)
-----

  src/tests/reservation_endpoints_tests.cpp 505c5421e95378177a7a09f462e5625ffa75cd37 


Diff: https://reviews.apache.org/r/58951/diff/3/

Changes: https://reviews.apache.org/r/58951/diff/2-3/


Testing
-------

`make check`, also in repetition.

While this patch is part of this series since later patches depend on it, it could be commited
independently.


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message