mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 59545: Added a test to verify the agent flag 'executor_reregistration_timeout'.
Date Tue, 06 Jun 2017 20:14:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59545/#review177083
-----------------------------------------------------------



Also remove `this->` from the flag creation helpers if not necessary.

- Greg Mann


On May 30, 2017, 11:29 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59545/
> -----------------------------------------------------------
> 
> (Updated May 30, 2017, 11:29 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Benjamin Mahler, and Vinod Kone.
> 
> 
> Bugs: MESOS-7540
>     https://issues.apache.org/jira/browse/MESOS-7540
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds a test to verify the correct behavior of
> the agent flag 'executor_reregistration_timeout.
> 
> 
> Diffs
> -----
> 
>   src/tests/slave_tests.cpp 927b9c3fbc3373b49c799da6e3f770b73964f9e5 
> 
> 
> Diff: https://reviews.apache.org/r/59545/diff/5/
> 
> 
> Testing
> -------
> 
> `bin/mesos-tests.sh --gtest_filter="*ExecutorReregistrationTimeoutFlag*" --gtest_repeat=-1
--gtest_break_on_failure`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message