mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 59099: Enabled authorization for v1 API call UPDATE_MAINTENANCE_SCHEDULE.
Date Sat, 10 Jun 2017 17:44:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59099/#review177533
-----------------------------------------------------------




src/master/http.cpp
Lines 4114-4115 (patched)
<https://reviews.apache.org/r/59099/#comment251163>

    Indented too far.



src/master/http.cpp
Line 4098 (original), 4139-4141 (patched)
<https://reviews.apache.org/r/59099/#comment251164>

    You could do without the lambda here, right?
    
    ```
    .then(defer(
        master->self(),
        &Master::Http::___updateMaintenanceSchedule,
        schedule,
        lambda::_1));
    ```



src/tests/api_tests.cpp
Lines 1165 (patched)
<https://reviews.apache.org/r/59099/#comment251167>

    Indented too far.



src/tests/api_tests.cpp
Lines 1170 (patched)
<https://reviews.apache.org/r/59099/#comment251173>

    Looking at some other tests in this file, I don't think `this->` is actually necessary
here. Would you mind removing it?


- Greg Mann


On June 7, 2017, 1:01 p.m., Alexander Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59099/
> -----------------------------------------------------------
> 
> (Updated June 7, 2017, 1:01 p.m.)
> 
> 
> Review request for mesos, Adam B, Greg Mann, and Till Toenshoff.
> 
> 
> Bugs: MESOS-7415
>     https://issues.apache.org/jira/browse/MESOS-7415
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Enables the use of authorization for the `UPDATE_MAINTENANCE_SCHEDULE`
> v1 API call, using the ACL `UpdateMaintenanceSchedule` and the action
> of the same name as the API call.
> 
> It also updates the ApiTests to take into account the authorization
> case.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 1dcfe6ef00b0e3984deb79a511e665f638661323 
>   src/master/master.hpp e8ddddf273256b14cde1cac390163f948241757f 
>   src/tests/api_tests.cpp 91b3473452b8e65cab9f2e873837d64a0edf4b54 
> 
> 
> Diff: https://reviews.apache.org/r/59099/diff/7/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message