mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rojas <alexan...@mesosphere.io>
Subject Re: Review Request 59100: Enabled authz on API calls which retrieve maintenance schedules.
Date Mon, 12 Jun 2017 14:08:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59100/
-----------------------------------------------------------

(Updated June 12, 2017, 4:08 p.m.)


Review request for mesos, Adam B, Greg Mann, and Till Toenshoff.


Summary (updated)
-----------------

Enabled authz on API calls which retrieve maintenance schedules.


Bugs: MESOS-7415
    https://issues.apache.org/jira/browse/MESOS-7415


Repository: mesos


Description (updated)
-------

Enables the use of authorization for the endpoint
'/maintenance/schedule' as well as the 'GET_MAINTENANCE_SCHEDULE' v1
API call, using the ACL 'GetMaintenanceSchedule' and the action of the
same name as the API call.

It also updates the ApiTests to take into account the authorization
case.


Diffs (updated)
-----

  src/master/http.cpp 1dcfe6ef00b0e3984deb79a511e665f638661323 
  src/master/master.hpp e8ddddf273256b14cde1cac390163f948241757f 
  src/tests/api_tests.cpp 91b3473452b8e65cab9f2e873837d64a0edf4b54 


Diff: https://reviews.apache.org/r/59100/diff/7/

Changes: https://reviews.apache.org/r/59100/diff/6-7/


Testing
-------

make check


Thanks,

Alexander Rojas


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message