From reviews-return-63320-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Thu Jul 13 00:11:12 2017 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 192E41A40D for ; Thu, 13 Jul 2017 00:11:12 +0000 (UTC) Received: (qmail 74464 invoked by uid 500); 13 Jul 2017 00:11:12 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 74427 invoked by uid 500); 13 Jul 2017 00:11:11 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 74416 invoked by uid 99); 13 Jul 2017 00:11:11 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 13 Jul 2017 00:11:11 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 312A51810D7; Thu, 13 Jul 2017 00:11:11 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.25 X-Spam-Level: *** X-Spam-Status: No, score=3.25 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id DhjVrxisDhMw; Thu, 13 Jul 2017 00:11:10 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 4D14E623EF; Thu, 13 Jul 2017 00:11:09 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id B4D35E0069; Thu, 13 Jul 2017 00:11:08 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id A491AC40071; Thu, 13 Jul 2017 00:11:08 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3260198843891370345==" MIME-Version: 1.0 Subject: Re: Review Request 60520: Removed posix/subprocess.hpp dependencies. From: Greg Mann To: Greg Mann , Alexander Rukletsov Cc: James Peach , mesos Date: Thu, 13 Jul 2017 00:11:08 -0000 Message-ID: <20170713001108.34494.9454@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Greg Mann X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/60520/ X-Sender: Greg Mann X-ReviewBoard-ShipIt: 1 References: <20170628224929.27613.92428@reviews-vm2.apache.org> In-Reply-To: <20170628224929.27613.92428@reviews-vm2.apache.org> X-ReviewBoard-ShipIt-Only: 1 Reply-To: Greg Mann X-ReviewRequest-Repository: mesos --===============3260198843891370345== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60520/#review180380 ----------------------------------------------------------- Ship it! Ship It! - Greg Mann On June 28, 2017, 10:49 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60520/ > ----------------------------------------------------------- > > (Updated June 28, 2017, 10:49 p.m.) > > > Review request for mesos, Alexander Rukletsov and Greg Mann. > > > Bugs: MESOS-7778 > https://issues.apache.org/jira/browse/MESOS-7778 > > > Repository: mesos > > > Description > ------- > > Fix a number of places where we were depending on symbols made > visible by . In most cases, this is > just tweaking the includes, but in the Checker we just duplicate > the trivial fork(2) helper since that is easer than trying to > export it as a libprocess API. > > > Diffs > ----- > > src/checks/checker_process.cpp 66f5452bb5f9c7f45819c221be7b098e5999b7a7 > src/slave/containerizer/mesos/isolators/volume/image.cpp c89af3e0a16f769c45f2846d1e76baedb8248d4d > src/uri/fetchers/docker.cpp 7f3e4e73d1dc5d15f875e2890acbe5369fb59d78 > > > Diff: https://reviews.apache.org/r/60520/diff/5/ > > > Testing > ------- > > make check (Fedora 26). > > > Thanks, > > James Peach > > --===============3260198843891370345==--