mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <an...@apache.org>
Subject Re: Review Request 61222: Added V1 teardown Call.
Date Thu, 03 Aug 2017 18:23:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61222/#review182132
-----------------------------------------------------------




src/master/http.cpp
Lines 3776-3779 (patched)
<https://reviews.apache.org/r/61222/#comment257979>

    uh oh! There is a race condition here that can crash the master. It's possible that the
master removed the framework by the time the continuation function is executed :-)
    
    Can you rename the existing teardown that exists to `__teardown` and make this function
invoke that? Also, goes for L3751


- Anand Mazumdar


On Aug. 3, 2017, 5:56 p.m., Quinn Leng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61222/
> -----------------------------------------------------------
> 
> (Updated Aug. 3, 2017, 5:56 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Greg Mann.
> 
> 
> Bugs: MESOS-6846
>     https://issues.apache.org/jira/browse/MESOS-6846
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added V1 call support for teardown operation.
> 
> 
> Diffs
> -----
> 
>   include/mesos/master/master.proto 0e4c30e3df704a929a3bd2e1787a76421d14a983 
>   include/mesos/v1/master/master.proto c04fd1602396a58086331f5fa56518c5dee9af89 
>   src/master/http.cpp 9df086c417a9392f62d600c7a6486be0a1cf7e70 
>   src/master/master.hpp 84465af782d4024f22463d981ef9d0ef7827d043 
>   src/master/validation.cpp 4885339b2112b6dbdc930875c20e1f5872b1edbf 
> 
> 
> Diff: https://reviews.apache.org/r/61222/diff/2/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Quinn Leng
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message