mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Re: Review Request 61406: Introduced `--share_pid_namespace` agent flag.
Date Thu, 03 Aug 2017 21:33:54 GMT


> On Aug. 3, 2017, 9:29 a.m., Jie Yu wrote:
> > why we need this flag? I think we need a way for operator to prevent top level containers
on a host to share with agent pid namespace.

@Qian, I guess you are trying to simplify the agent flag name, but I think we may want to
emphasize that:
1. this is for top level container only
2. it is operator specific

Do you have anyother concern for the flag name mentioned in the JIRA?


- Gilbert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61406/#review182120
-----------------------------------------------------------


On Aug. 3, 2017, 8:20 a.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61406/
> -----------------------------------------------------------
> 
> (Updated Aug. 3, 2017, 8:20 a.m.)
> 
> 
> Review request for mesos, Gastón Kleiman, Gilbert Song, Jie Yu, Kevin Klues, and Vinod
Kone.
> 
> 
> Bugs: MESOS-7853
>     https://issues.apache.org/jira/browse/MESOS-7853
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Introduced `--share_pid_namespace` agent flag.
> 
> 
> Diffs
> -----
> 
>   docs/configuration.md 041c3dfb9c0c1718770f74dfb33a9f5d6fbe9b61 
>   src/slave/flags.hpp 032880dfa68cd29420e559d34e592e57827cfc07 
>   src/slave/flags.cpp 4171604090ffebe79fa35579458cabff7270c0de 
> 
> 
> Diff: https://reviews.apache.org/r/61406/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message