mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 61434: Updated health-checks.md to include description of generalized checks.
Date Fri, 04 Aug 2017 19:18:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61434/#review182234
-----------------------------------------------------------


Fix it, then Ship it!




This is great!


docs/health-checks.md
Lines 110 (patched)
<https://reviews.apache.org/r/61434/#comment258116>

    s/1./2./ ? or is this markdown style?



docs/health-checks.md
Lines 118 (patched)
<https://reviews.apache.org/r/61434/#comment258117>

    /transitions./transitions and make global decisions/



docs/health-checks.md
Lines 136 (patched)
<https://reviews.apache.org/r/61434/#comment258118>

    I know you mentioned about check de-duplication above, but worthwhile mentioning it here
as well to contrast.



docs/health-checks.md
Lines 138 (patched)
<https://reviews.apache.org/r/61434/#comment258119>

    Docker executor currently supports health checks but not checks.



docs/health-checks.md
Lines 141 (patched)
<https://reviews.apache.org/r/61434/#comment258120>

    s/reasons,/reasons;/



docs/health-checks.md
Lines 162 (patched)
<https://reviews.apache.org/r/61434/#comment258121>

    s/adheres/adheres to/



docs/health-checks.md
Lines 209 (patched)
<https://reviews.apache.org/r/61434/#comment258125>

    Is it 127.0.0.1 even in the CNI network case? cc @avinash


- Vinod Kone


On Aug. 4, 2017, 6:14 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61434/
> -----------------------------------------------------------
> 
> (Updated Aug. 4, 2017, 6:14 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman, Greg Mann, and Vinod Kone.
> 
> 
> Bugs: MESOS-7349
>     https://issues.apache.org/jira/browse/MESOS-7349
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   docs/health-checks.md d0749347d1f9398004e56b03503d655b5fba75f4 
> 
> 
> Diff: https://reviews.apache.org/r/61434/diff/1/
> 
> 
> Testing
> -------
> 
> https://gist.github.com/rukletsov/517a136cb6a0e8b909db30b36b13eded
> 
> Additionally rendered in MacDown.
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message