mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gastón Kleiman <gas...@mesosphere.io>
Subject Re: Review Request 61387: Made the rlimits isolator work with nested containers.
Date Fri, 04 Aug 2017 21:15:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61387/
-----------------------------------------------------------

(Updated Aug. 4, 2017, 9:15 p.m.)


Review request for mesos, Benjamin Bannier and Jie Yu.


Changes
-------

Addressed feedback.


Bugs: MESOS-7849
    https://issues.apache.org/jira/browse/MESOS-7849


Repository: mesos


Description
-------

Make the rlimits isolator support nesting. Without this patch rlimits
sets for tasks launched by the DefaultExecutor are silently ignored.


Diffs (updated)
-----

  src/slave/containerizer/mesos/isolators/posix/rlimits.hpp ee36a24ae36179d3ff3141f8c3cdc768b1e399af

  src/slave/containerizer/mesos/isolators/posix/rlimits.cpp 3fc2b3dbd5b382e422c948adae0dc50f4fbcfc49

  src/tests/containerizer/posix_rlimits_isolator_tests.cpp b7ccc7eeeb7e4d0d8f4fd463d506cfe7157076a4



Diff: https://reviews.apache.org/r/61387/diff/3/

Changes: https://reviews.apache.org/r/61387/diff/2-3/


Testing
-------

`bin/mesos-tests.sh --gtest_filter="PosixRLimitsIsolatorTest.NestedContainers" --gtest_repeat=1000
--gtest_break_on_failure` passed on a machine running GNU/Linux.


Thanks,

Gastón Kleiman


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message