mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gastón Kleiman <gas...@mesosphere.io>
Subject Re: Review Request 61406: Introduced `--disallow_top_level_pid_ns_sharing` agent flag.
Date Sat, 05 Aug 2017 00:44:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61406/#review182249
-----------------------------------------------------------


Fix it, then Ship it!





docs/configuration.md
Lines 2052-2054 (patched)
<https://reviews.apache.org/r/61406/#comment258143>

    s/pid namespace/PID namespace/g



docs/configuration.md
Lines 2054 (patched)
<https://reviews.apache.org/r/61406/#comment258144>

    s/ignored if `namespaces/pid`/ignored if the `namespaces/pid`/



src/slave/flags.cpp
Lines 453-458 (patched)
<https://reviews.apache.org/r/61406/#comment258146>

    Ditto.


- Gastón Kleiman


On Aug. 4, 2017, 4 p.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61406/
> -----------------------------------------------------------
> 
> (Updated Aug. 4, 2017, 4 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman, Gilbert Song, Jie Yu, Kevin Klues, and Vinod
Kone.
> 
> 
> Bugs: MESOS-7853
>     https://issues.apache.org/jira/browse/MESOS-7853
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Introduced `--disallow_top_level_pid_ns_sharing` agent flag.
> 
> 
> Diffs
> -----
> 
>   docs/configuration.md 041c3dfb9c0c1718770f74dfb33a9f5d6fbe9b61 
>   src/slave/flags.hpp 032880dfa68cd29420e559d34e592e57827cfc07 
>   src/slave/flags.cpp 4171604090ffebe79fa35579458cabff7270c0de 
> 
> 
> Diff: https://reviews.apache.org/r/61406/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message