mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhq527...@gmail.com>
Subject Review Request 61463: Fixed a bug in the test `NamespacesIsolatorTest.ROOT_PidNamespace`.
Date Mon, 07 Aug 2017 15:12:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61463/
-----------------------------------------------------------

Review request for mesos, Gastón Kleiman, Gilbert Song, Jie Yu, Kevin Klues, and Vinod Kone.


Repository: mesos


Description
-------

In this test, we used the command `stat -c %i /proc/self/ns/pid` to
get the current process's pid namespace inode, that is not correct
since `/proc/self/ns/pid` is a symbol link, we should get the inode
that the link references rather than the link itself. So we need to
add a `-L` option in the `stat` command.


Diffs
-----

  src/tests/containerizer/isolator_tests.cpp f3c541c92f8ecc5c12356363bbbf3561d3b75230 


Diff: https://reviews.apache.org/r/61463/diff/1/


Testing
-------


Thanks,

Qian Zhang


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message