mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 61476: Used clone instead of fork in ns::clone.
Date Mon, 07 Aug 2017 21:36:07 GMT


> On Aug. 7, 2017, 9:34 p.m., Greg Mann wrote:
> > src/linux/ns.hpp
> > Lines 538-539 (original), 585-586 (patched)
> > <https://reviews.apache.org/r/61476/diff/1/?file=1790944#file1790944line585>
> >
> >     Should this comment be removed?

Sorry, I mean maybe it should be updated to mention 'clone' instead of 'fork'?


- Greg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61476/#review182325
-----------------------------------------------------------


On Aug. 7, 2017, 8:02 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61476/
> -----------------------------------------------------------
> 
> (Updated Aug. 7, 2017, 8:02 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Benjamin Mahler, and Joseph Wu.
> 
> 
> Bugs: MESOS-7858
>     https://issues.apache.org/jira/browse/MESOS-7858
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Used clone instead of fork in ns::clone.
> 
> 
> Diffs
> -----
> 
>   src/linux/ns.hpp 941c7ee243e0e486ee263a9e6c4f6d0a7398427d 
> 
> 
> Diff: https://reviews.apache.org/r/61476/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message