mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhq527...@gmail.com>
Subject Re: Review Request 61463: Fixed a bug in the test `NamespacesIsolatorTest.ROOT_PidNamespace`.
Date Tue, 08 Aug 2017 01:33:31 GMT


> On Aug. 8, 2017, 8:05 a.m., Gastón Kleiman wrote:
> > src/tests/containerizer/isolator_tests.cpp
> > Line 176 (original), 176 (patched)
> > <https://reviews.apache.org/r/61463/diff/1/?file=1790647#file1790647line176>
> >
> >     `/proc/self/ns/ipc` is also a symlink, should we change this line too?

Good catch!


- Qian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61463/#review182344
-----------------------------------------------------------


On Aug. 7, 2017, 11:12 p.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61463/
> -----------------------------------------------------------
> 
> (Updated Aug. 7, 2017, 11:12 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman, Gilbert Song, Jie Yu, Kevin Klues, and Vinod
Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> In this test, we used the command `stat -c %i /proc/self/ns/pid` to
> get the current process's pid namespace inode, that is not correct
> since `/proc/self/ns/pid` is a symbol link, we should get the inode
> that the link references rather than the link itself. So we need to
> add a `-L` option in the `stat` command.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/isolator_tests.cpp f3c541c92f8ecc5c12356363bbbf3561d3b75230

> 
> 
> Diff: https://reviews.apache.org/r/61463/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message