mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Budnik <abud...@mesosphere.com>
Subject Review Request 61524: Moved task validation from `getExecutorInfo` to `runTask` on agent.
Date Wed, 09 Aug 2017 13:14:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61524/
-----------------------------------------------------------

Review request for mesos, Benjamin Mahler, Greg Mann, and Vinod Kone.


Bugs: MESOS-7871
    https://issues.apache.org/jira/browse/MESOS-7871


Repository: mesos


Description
-------

Previously, `getExecutorInfo` was called only in `runTask`, so it was
validating an invariant related to launching a single task. The
invariant is that a task should have either CommandInfo or ExecutorInfo
set but not both. Now `getExecutorInfo` is also called to calculate
allocated resources which might be related to a task group, which might
violate the invariant.


Diffs
-----

  src/slave/slave.cpp 7381530515f86faf4c3e8f82bcd9483f6cf0498b 


Diff: https://reviews.apache.org/r/61524/diff/1/


Testing
-------

sudo make check


Thanks,

Andrei Budnik


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message