mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 61534: Added test to verify the fix for a failed agent assertion.
Date Wed, 09 Aug 2017 18:34:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61534/#review182511
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/slave_tests.cpp
Lines 1825 (patched)
<https://reviews.apache.org/r/61534/#comment258422>

    Maybe clarify here that we just want to make sure it doesn't crsah? Ideally we would be
looking to make sure the pending tasks show up (which I hope we already have a test for for
non task groups?)


- Benjamin Mahler


On Aug. 9, 2017, 6:28 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61534/
> -----------------------------------------------------------
> 
> (Updated Aug. 9, 2017, 6:28 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Benjamin Mahler.
> 
> 
> Bugs: MESOS-7871
>     https://issues.apache.org/jira/browse/MESOS-7871
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds 'SlaveTest.GetStateTaskGroupPending', which confirms
> the fix for MESOS-7871. The test verifies that requests to the agent's
> '/state' endpoint are successful when there are pending tasks on the
> agent which were launched as part of a task group.
> 
> 
> Diffs
> -----
> 
>   src/tests/slave_tests.cpp 1d9d142ed9e801b79535a2c28f5a94ffbf1bf160 
> 
> 
> Diff: https://reviews.apache.org/r/61534/diff/1/
> 
> 
> Testing
> -------
> 
> `bin/mesos-tests.sh --gtest_filter="*GetStateTaskGroupPending*" --gtest_repeat=1000`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message