mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Till Toenshoff <toensh...@me.com>
Subject Re: Review Request 61495: Removed table from markdown and added cross-links.
Date Thu, 10 Aug 2017 01:56:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61495/#review182549
-----------------------------------------------------------




docs/home.md
Lines 70 (patched)
<https://reviews.apache.org/r/61495/#comment258455>

    We may want to consider calling these "task state reasons" instead. 
    
    s/mesos/Mesos/
    
    We generally use initial capitals for product and company names.



docs/task-reasons.md
Line 1 (original), 1 (patched)
<https://reviews.apache.org/r/61495/#comment258461>

    "Task State Reasons" makes more sense to me.



docs/task-reasons.md
Lines 49 (patched)
<https://reviews.apache.org/r/61495/#comment258462>

    Can we avoid HTML code here? We typically used HTML for getting tables properly formatted
as the apache site rendering otherwise caused issues in the resulting HTML code.
    
    If not done already, I would suggest you to play with the site renderer a bit to see if
the results are actually what you are hoping for.



include/mesos/mesos.proto
Lines 2149-2150 (original)
<https://reviews.apache.org/r/61495/#comment258464>

    Avoiding duplication by moving this comment into the implementation seems a good move
to me.


- Till Toenshoff


On Aug. 9, 2017, 3:41 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61495/
> -----------------------------------------------------------
> 
> (Updated Aug. 9, 2017, 3:41 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Till Toenshoff.
> 
> 
> Bugs: MESOS-5078
>     https://issues.apache.org/jira/browse/MESOS-5078
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Removed table from markdown and added cross-links.
> 
> 
> Diffs
> -----
> 
>   docs/home.md ab32838f621de76498262c9dd04e1cf01f8378ca 
>   docs/task-reasons.md PRE-CREATION 
>   include/mesos/mesos.proto f31f5bdc2ace2b261885b252e7c01ceb9b76c461 
>   include/mesos/v1/mesos.proto 66386a84bc21989d1c1237e629d5d04662a368fa 
>   src/master/master.cpp 43cb6977ca58dce1808e4bdb2d109d549622beb9 
> 
> 
> Diff: https://reviews.apache.org/r/61495/diff/2/
> 
> 
> Testing
> -------
> 
> None
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message