mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 61435: Added logging in docker executor on `docker stop` failure.
Date Thu, 10 Aug 2017 12:10:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61435/#review182575
-----------------------------------------------------------


Fix it, then Ship it!





src/docker/executor.cpp
Lines 415 (patched)
<https://reviews.apache.org/r/61435/#comment258501>

    s/string &/ string&


- Alexander Rukletsov


On Aug. 4, 2017, 6:34 p.m., Andrei Budnik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61435/
> -----------------------------------------------------------
> 
> (Updated Aug. 4, 2017, 6:34 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-6743
>     https://issues.apache.org/jira/browse/MESOS-6743
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added logging in docker executor on `docker stop` failure.
> 
> 
> Diffs
> -----
> 
>   src/docker/executor.cpp 26f12ec002f754fab0d34c01472cf95b499d8007 
> 
> 
> Diff: https://reviews.apache.org/r/61435/diff/1/
> 
> 
> Testing
> -------
> 
> Manual testing steps:
> 1. force docker daemon to always return error: https://github.com/docker/docker-ce/blob/master/components/engine/daemon/stop.go#L21
> 2. build docker from sources and run it
> 3. run master, agent
> 4. launch a task using docker executor via mesos-execute in terminal
> 5. send SIGINT to the launched mesos-execute
> 6. check stderr logs of an executor in its sandbox
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message