mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@mesosphere.io>
Subject Re: Review Request 61588: Added a `--skip-style-check` option when applying reviews.
Date Fri, 11 Aug 2017 16:25:58 GMT


> On Aug. 11, 2017, 9:02 a.m., Benjamin Bannier wrote:
> > support/apply-reviews.py
> > Line 364 (original), 371-373 (patched)
> > <https://reviews.apache.org/r/61588/diff/1/?file=1795426#file1795426line371>
> >
> >     Since this prevents running any (pre-)commit hooks, I wonder if we should give
this a more general name, e.g., simply expose `[-n|--no-verify]`.

If we use `--no-verify` a the long option, then the short option `-n` would conflict with
`--no-amend`, and it seems to me that we should not change what's already there. And `-v`
looks like `--verbose` and also not obvious to see it's *not* doing a verification. Keviv
and I looked through the keyboard and came up with this one.


- Chun-Hung


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61588/#review182670
-----------------------------------------------------------


On Aug. 10, 2017, 11:41 p.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61588/
> -----------------------------------------------------------
> 
> (Updated Aug. 10, 2017, 11:41 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Jie Yu, and Kevin Klues.
> 
> 
> Bugs: MESOS-7880
>     https://issues.apache.org/jira/browse/MESOS-7880
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a `--skip-style-check` option when applying reviews.
> 
> 
> Diffs
> -----
> 
>   support/apply-reviews.py aa2eb8d23bed52a4f33510c53ace2c63bd66ec49 
> 
> 
> Diff: https://reviews.apache.org/r/61588/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message