mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 61434: Updated health-checks.md to include description of generalized checks.
Date Fri, 11 Aug 2017 18:04:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61434/#review182718
-----------------------------------------------------------




docs/health-checks.md
Line 29 (original), 29 (patched)
<https://reviews.apache.org/r/61434/#comment258692>

    s/defines/which defines a/



docs/health-checks.md
Lines 36 (patched)
<https://reviews.apache.org/r/61434/#comment258693>

    s/task's/tasks'/



docs/health-checks.md
Lines 74 (patched)
<https://reviews.apache.org/r/61434/#comment258694>

    s/certain condition/a certain condition/



docs/health-checks.md
Lines 75 (patched)
<https://reviews.apache.org/r/61434/#comment258695>

    s/of specific/of a specific/



docs/health-checks.md
Lines 80-83 (patched)
<https://reviews.apache.org/r/61434/#comment258696>

    I can't figure out precisely what is being said here; could you try to re-word?



docs/health-checks.md
Lines 85-86 (patched)
<https://reviews.apache.org/r/61434/#comment258698>

    What do you mean by "only the executor knows how to interpret `TaskInfo`"?
    
    I might replace with something like:
    
    "It is the responsibility of the executor to interpret `CheckInfo` and `HealthCheckInfo`
and perform checks appropriately."



docs/health-checks.md
Lines 86 (patched)
<https://reviews.apache.org/r/61434/#comment258697>

    s/only executor/only the executor/



docs/health-checks.md
Lines 97 (patched)
<https://reviews.apache.org/r/61434/#comment258699>

    s/checking all/checking that all/



docs/health-checks.md
Lines 102 (patched)
<https://reviews.apache.org/r/61434/#comment258700>

    s/it/them/



docs/health-checks.md
Lines 109-112 (patched)
<https://reviews.apache.org/r/61434/#comment258702>

    Could you make the punctuation at the ends of these lines consistent?



docs/health-checks.md
Lines 110-112 (patched)
<https://reviews.apache.org/r/61434/#comment258701>

    Forgot to increment numbers: 2, 3



docs/health-checks.md
Lines 118 (patched)
<https://reviews.apache.org/r/61434/#comment258703>

    s/internal task's/the task's internal/



docs/health-checks.md
Lines 135 (patched)
<https://reviews.apache.org/r/61434/#comment258704>

    s/given HTTP/given that HTTP/



docs/health-checks.md
Lines 143 (patched)
<https://reviews.apache.org/r/61434/#comment258705>

    s/in the future/in the future the/



docs/health-checks.md
Lines 157 (patched)
<https://reviews.apache.org/r/61434/#comment258706>

    s/As/As the/



docs/health-checks.md
Lines 159 (patched)
<https://reviews.apache.org/r/61434/#comment258707>

    s/as few as possible updates/as few updates as possible/



docs/health-checks.md
Lines 272-278 (patched)
<https://reviews.apache.org/r/61434/#comment258712>

    Should we also call out here that setting interval_seconds to zero is a really bad idea?



docs/health-checks.md
Line 219 (original), 459 (patched)
<https://reviews.apache.org/r/61434/#comment258716>

    s/during first/during the first/
    
    s/response time/response times/



docs/health-checks.md
Lines 280-281 (original), 522-523 (patched)
<https://reviews.apache.org/r/61434/#comment258718>

    I might recommend:
    
    "Regardless of executor, all checks and health checks consume resources from the task's
resource allocation."



docs/health-checks.md
Line 281 (original), 523 (patched)
<https://reviews.apache.org/r/61434/#comment258717>

    s/towards task's/towards the task's/



docs/health-checks.md
Lines 539-541 (patched)
<https://reviews.apache.org/r/61434/#comment258719>

    I might recommend:
    
    "Due to its short-polling nature, a check whose state oscillates repeatedly may lead to
scalability issues due to a high volume of task status updates."


- Greg Mann


On Aug. 11, 2017, 12:12 a.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61434/
> -----------------------------------------------------------
> 
> (Updated Aug. 11, 2017, 12:12 a.m.)
> 
> 
> Review request for mesos, Gastón Kleiman, Greg Mann, and Vinod Kone.
> 
> 
> Bugs: MESOS-7349
>     https://issues.apache.org/jira/browse/MESOS-7349
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   docs/health-checks.md d0749347d1f9398004e56b03503d655b5fba75f4 
> 
> 
> Diff: https://reviews.apache.org/r/61434/diff/2/
> 
> 
> Testing
> -------
> 
> https://gist.github.com/rukletsov/517a136cb6a0e8b909db30b36b13eded
> 
> Additionally rendered in MacDown.
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message