mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Review Request 61602: Fixed mesos containerizer to support docker image WORKDIR missing.
Date Sat, 12 Aug 2017 01:04:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61602/
-----------------------------------------------------------

Review request for mesos, Jie Yu, Kevin Klues, and Qian Zhang.


Bugs: MESOS-7652
    https://issues.apache.org/jira/browse/MESOS-7652


Repository: mesos


Description
-------

Some docker image may have 'WORKDIR' set in its manifest but that
'WORKDIR' does not exist in the image rootfs (e.g., the workdir
is removed in the following dockerfile).

>From the reference of dockerfile, "If the WORKDIR doesn’t exist,
it will be created even if it’s not used in any subsequent
Dockerfile instruction". So we should create the working directory
if it does not exist in the image's rootfs.


Diffs
-----

  src/slave/containerizer/mesos/launch.cpp 8e662931697a2f20e0ac1e80a2911b96f646b5af 


Diff: https://reviews.apache.org/r/61602/diff/1/


Testing
-------

make

Manually tested using 'quay.io/spinnaker/front50:master' docker image.


Thanks,

Gilbert Song


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message