mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 60815: Prefer leading instead of trailing spaces for allocator log messages.
Date Mon, 14 Aug 2017 16:36:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60815/#review182873
-----------------------------------------------------------


Fix it, then Ship it!





src/master/allocator/mesos/hierarchical.cpp
Lines 1173-1174 (original), 1173-1174 (patched)
<https://reviews.apache.org/r/60815/#comment258816>

    Need to remove the trailing space.


- Greg Mann


On July 12, 2017, 9:49 p.m., Gastón Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60815/
> -----------------------------------------------------------
> 
> (Updated July 12, 2017, 9:49 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Greg Mann, and Vinod
Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Prefer leading instead of trailing spaces for allocator log messages.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.cpp f021c34ef11aac42026ba39c5a1b775794982035

> 
> 
> Diff: https://reviews.apache.org/r/60815/diff/3/
> 
> 
> Testing
> -------
> 
> Not a functional change.
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message