mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 60525: Fixed the default filter used by the allocator.
Date Mon, 14 Aug 2017 16:55:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60525/#review182874
-----------------------------------------------------------


Fix it, then Ship it!





CHANGELOG
Line 35 (original), 35 (patched)
<https://reviews.apache.org/r/60525/#comment258818>

    Nit: this change doesn't belong in this patch :)



docs/scheduler-http-api.md
Line 168 (original), 168 (patched)
<https://reviews.apache.org/r/60525/#comment258817>

    Let's tweak this line a bit to accommodate your new additions.
    
    How about moving the following portion:
    "Also, any of the offer's resources not used in the `ACCEPT` call (e.g., to launch a task
or task group) are considered declined and might be reoffered to other frameworks."
    
    and merging it with your next sentence, "The unused resources ..."


- Greg Mann


On Aug. 12, 2017, 1:07 a.m., Gastón Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60525/
> -----------------------------------------------------------
> 
> (Updated Aug. 12, 2017, 1:07 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Greg Mann, and Vinod
Kone.
> 
> 
> Bugs: MESOS-7660
>     https://issues.apache.org/jira/browse/MESOS-7660
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> If a framework accepts/refuses an offer using a very long filter, the
> `HierarchicalAllocator` will use the default filter instead. Meaning
> that it will filter the resources for only 5 seconds. This can happen
> when a framework sets `Filter::refuse_seconds` to a number of seconds
> larger than what fits in `Duration`.
> 
> This patch makes the hierarchical allocator cap the filter duration to
> at most 365 days.
> 
> 
> Diffs
> -----
> 
>   CHANGELOG abb0e3bea95648b91605cec37b21f079d2b15b41 
>   docs/scheduler-http-api.md 4a5d77b88ae7cf0a0d8d39fe2579eb68bf33059a 
>   include/mesos/mesos.proto 50a5caf2623fff7d371753cbc6e842779fbf9769 
>   include/mesos/v1/mesos.proto 9d47a8a3a2f10fa493b4db35a73f33e6ee1ac727 
>   src/master/allocator/mesos/hierarchical.cpp f021c34ef11aac42026ba39c5a1b775794982035

> 
> 
> Diff: https://reviews.apache.org/r/60525/diff/8/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message