mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 61570: Added the `kill()` function to the containerizer interface.
Date Mon, 14 Aug 2017 18:49:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61570/#review182883
-----------------------------------------------------------




src/slave/containerizer/mesos/containerizer.cpp
Lines 582 (patched)
<https://reviews.apache.org/r/61570/#comment258821>

    s/status/signal/



src/slave/containerizer/mesos/containerizer.cpp
Lines 587 (patched)
<https://reviews.apache.org/r/61570/#comment258822>

    s/status/signal/



src/slave/containerizer/mesos/containerizer.cpp
Lines 2455 (patched)
<https://reviews.apache.org/r/61570/#comment258828>

    Can you add a TODO to chain this on the launch completion future? Seems a bit unfortunate
to destroy the container irrespective of the signal.



src/slave/containerizer/mesos/containerizer.cpp
Lines 2466 (patched)
<https://reviews.apache.org/r/61570/#comment258830>

    s/running//



src/slave/containerizer/mesos/containerizer.cpp
Lines 2467 (patched)
<https://reviews.apache.org/r/61570/#comment258829>

    no need to include the container id because the caller knows it already.


- Vinod Kone


On Aug. 14, 2017, 5:20 p.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61570/
> -----------------------------------------------------------
> 
> (Updated Aug. 14, 2017, 5:20 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Vinod Kone.
> 
> 
> Bugs: MESOS-7879
>     https://issues.apache.org/jira/browse/MESOS-7879
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This would be used by now on for killing a container by sending
> a signal to it similar to the linux equivalent `kill()` system call.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/containerizer.hpp 0954ed6175e4c8f963bf371e54e0f9ffe7bc9c1c

>   src/slave/containerizer/mesos/containerizer.hpp fd586306f7a6d3d2cdb58481f0ef4906de8d0f88

>   src/slave/containerizer/mesos/containerizer.cpp ff192bb085f3554ad1b1f20fb73bf827bf04ef13

> 
> 
> Diff: https://reviews.apache.org/r/61570/diff/2/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message