mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 61483: Added a test using CMD health checks + DefaultExecutor w/ Docker image.
Date Tue, 15 Aug 2017 18:37:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61483/#review182980
-----------------------------------------------------------


Ship it!





src/tests/health_check_tests.cpp
Lines 2458 (patched)
<https://reviews.apache.org/r/61483/#comment258959>

    This is how one can still leave traces in the codebase long after abandoning the project
: )


- Alexander Rukletsov


On Aug. 7, 2017, 10:47 p.m., Gastón Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61483/
> -----------------------------------------------------------
> 
> (Updated Aug. 7, 2017, 10:47 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a test using CMD health checks + DefaultExecutor w/ Docker image.
> 
> 
> Diffs
> -----
> 
>   src/tests/health_check_tests.cpp e824d1b2c2b17423394da0b089ae8940450378b7 
> 
> 
> Diff: https://reviews.apache.org/r/61483/diff/1/
> 
> 
> Testing
> -------
> 
> `bin/mesos-tests.sh --gtest_filter="HealthCheckTest.DefaultExecutorWithDockerImageCommandHealthCheck"`
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message