mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <an...@apache.org>
Subject Review Request 61693: Fixed a bug around the `kill()` not removing active containers.
Date Wed, 16 Aug 2017 17:27:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61693/
-----------------------------------------------------------

Review request for mesos, Gastón Kleiman, Gilbert Song, and Vinod Kone.


Repository: mesos


Description
-------

The composing containerizer relies on users invoking `destroy()`
for removing the container from the list of active containers.
However, when using `kill()` the relevant containerizer just
reaps the container without notifying the composing containerizer
i.e., there is no `destroy()` invocation from the user. This change
chains on the `wait()` future to invoke `destroy()` that
eventually does the cleanup.


Diffs
-----

  src/slave/containerizer/composing.cpp f1a9c3d08b408aa61198f4042b9274df88b789ea 


Diff: https://reviews.apache.org/r/61693/diff/1/


Testing
-------

sudo make check (tests pass)


Thanks,

Anand Mazumdar


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message