mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <an...@apache.org>
Subject Re: Review Request 61575: Added a test for verifying signal escalation on the default executor.
Date Wed, 16 Aug 2017 19:15:07 GMT


> On Aug. 14, 2017, 7:04 p.m., Gastón Kleiman wrote:
> > src/tests/default_executor_tests.cpp
> > Lines 600 (patched)
> > <https://reviews.apache.org/r/61575/diff/2/?file=1796675#file1796675line600>
> >
> >     s/EXPECT_NE(0, offers->offers().size());/EXPECT_FALSE(offers->offers().empty)());

I used `ASSERT_NE` instead.


> On Aug. 14, 2017, 7:04 p.m., Gastón Kleiman wrote:
> > src/tests/default_executor_tests.cpp
> > Lines 613-661 (patched)
> > <https://reviews.apache.org/r/61575/diff/2/?file=1796675#file1796675line613>
> >
> >     What do you think about the following shorter (and IMHO more readable) approach?
> >     
> >     ```
> >       v1::Offer::Operation launchGroup = v1::LAUNCH_GROUP(
> >           executorInfo,
> >           v1::createTaskGroupInfo({taskInfo}));
> >     
> >       Future<v1::scheduler::Event::Update> update1;
> >       EXPECT_CALL(*scheduler, update(_, _))
> >         .WillOnce(DoAll(
> >             FutureArg<1>(&update1),
> >             v1::scheduler::SendAcknowledge(
> >                 frameworkId,
> >                 offer.agent_id())));
> >     
> >       mesos.send(v1::createCallAccept(
> >           frameworkId,
> >           offer,
> >           {reserve, create, launchGroup}));
> >     ```

We need to do a sweep of the file before using these new helpers first to be consistent within
this file.


- Anand


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61575/#review182895
-----------------------------------------------------------


On Aug. 16, 2017, 7:14 p.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61575/
> -----------------------------------------------------------
> 
> (Updated Aug. 16, 2017, 7:14 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-7879
>     https://issues.apache.org/jira/browse/MESOS-7879
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This test uses the kill policy helper and blocks the SIGTERM signal.
> 
> Review: https://reviews.apache.org/r/61575
> 
> 
> Diffs
> -----
> 
>   src/tests/default_executor_tests.cpp afe0afabf784fb65eb833beadd3c584722c321e1 
>   src/tests/kill_policy_test_helper.hpp 29651102ec46b477e6e797c6e6bdef5b10afa665 
>   src/tests/kill_policy_test_helper.cpp a1880595ff015475f1ba49437d49f7397da19422 
> 
> 
> Diff: https://reviews.apache.org/r/61575/diff/4/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message