mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhq527...@gmail.com>
Subject Re: Review Request 61536: Added network ports isolator socket utilities tests.
Date Thu, 17 Aug 2017 09:10:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61536/#review183113
-----------------------------------------------------------




src/tests/containerizer/ports_isolator_tests.cpp
Lines 83-85 (patched)
<https://reviews.apache.org/r/61536/#comment259120>

    Since we only want to compare the port (but not IP), why do we need to construct this
object? What about just compare `ntohs(info.sourcePort.get()` and `processAddress.port`?



src/tests/containerizer/ports_isolator_tests.cpp
Lines 88 (patched)
<https://reviews.apache.org/r/61536/#comment259119>

    s/ie./i.e./


- Qian Zhang


On Aug. 15, 2017, 7:41 a.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61536/
> -----------------------------------------------------------
> 
> (Updated Aug. 15, 2017, 7:41 a.m.)
> 
> 
> Review request for mesos, Qian Zhang and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-7675
>     https://issues.apache.org/jira/browse/MESOS-7675
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added some basic tests for the network ports isolator socket utilities.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 68fff148f3d0c1710305bd9afcba62336d194b55 
>   src/tests/containerizer/ports_isolator_tests.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/61536/diff/2/
> 
> 
> Testing
> -------
> 
> make check (Fedora 26)
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message