mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 61697: Included nested command checks output in the executor logs.
Date Thu, 17 Aug 2017 14:22:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61697/#review183121
-----------------------------------------------------------




src/checks/checker_process.cpp
Lines 144-145 (patched)
<https://reviews.apache.org/r/61697/#comment259125>

    Insert a blank line here.



src/checks/checker_process.cpp
Lines 629 (patched)
<https://reviews.apache.org/r/61697/#comment259137>

    Why not always printing the output? So that a reader clearly sees that there were no output
and no errors.



src/checks/checker_process.cpp
Lines 630 (patched)
<https://reviews.apache.org/r/61697/#comment259127>

    Maybe `std::endl` instead of `\n`? `\n` is not Windows-friendly.



src/checks/checker_process.cpp
Lines 630-631 (patched)
<https://reviews.apache.org/r/61697/#comment259129>

    I assume line feed and carriage return characters are included in the output. In this
case, how a reader can distinguish between executor output and check output? Is it because
check output lines will not be prepended by a timestamp? Have you tested it and checked that
the output is sane?



src/checks/checker_process.cpp
Lines 855-858 (original), 903-906 (patched)
<https://reviews.apache.org/r/61697/#comment259144>

    While we're on it, let's consistently print out HTTP and TCP check output. Instead of
including it into the failure. As a separate patch, please.



src/checks/checker_process.cpp
Lines 999-1009 (original), 1047-1057 (patched)
<https://reviews.apache.org/r/61697/#comment259146>

    Ditto. Let's make the output consistent.


- Alexander Rukletsov


On Aug. 16, 2017, 8:17 p.m., Gastón Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61697/
> -----------------------------------------------------------
> 
> (Updated Aug. 16, 2017, 8:17 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Vinod Kone.
> 
> 
> Bugs: MESOS-7861
>     https://issues.apache.org/jira/browse/MESOS-7861
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch makes the default executor include the output of the COMMAND
> (health) checks in its logs.
> 
> 
> Diffs
> -----
> 
>   src/checks/checker_process.cpp 30dda0e6efca31aa6b9cd4f753f96b979717ab2e 
> 
> 
> Diff: https://reviews.apache.org/r/61697/diff/2/
> 
> 
> Testing
> -------
> 
> Manual tests.
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message