mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 61495: Add documentation for possible task reasons.
Date Thu, 17 Aug 2017 22:29:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61495/#review183161
-----------------------------------------------------------




docs/task-state-reasons.md
Lines 55-58 (patched)
<https://reviews.apache.org/r/61495/#comment259183>

    Duplicate of the above?



docs/task-state-reasons.md
Lines 158-163 (patched)
<https://reviews.apache.org/r/61495/#comment259185>

    Maybe merge it with the previous one? Otherwise people might not notice that there is
another reason documented in a separate section.



docs/task-state-reasons.md
Lines 178-197 (patched)
<https://reviews.apache.org/r/61495/#comment259190>

    Ditto as above.



docs/task-state-reasons.md
Lines 358-369 (patched)
<https://reviews.apache.org/r/61495/#comment259192>

    I think a custom executor can set these reasons even for terminal updates. However, this
is true for all executor-induced updates.
    
    I don't think we ever will set these reasons for `TASK_STAGING`, because this is sent
before the task is launched by an agent and never by an executor.
    
    Let's mention that currently (i.e. Mesos 1.4.0) all built-in executors set these reasons
only for `TASK_RUNNING`.



docs/task-state-reasons.md
Lines 360 (patched)
<https://reviews.apache.org/r/61495/#comment259193>

    Not sure this is true.



docs/task-state-reasons.md
Lines 367 (patched)
<https://reviews.apache.org/r/61495/#comment259194>

    Ditto.



include/mesos/mesos.proto
Lines 2148 (patched)
<https://reviews.apache.org/r/61495/#comment259191>

    task-state-reasons.md?


- Alexander Rukletsov


On Aug. 10, 2017, 2:01 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61495/
> -----------------------------------------------------------
> 
> (Updated Aug. 10, 2017, 2:01 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, James Peach, and Till Toenshoff.
> 
> 
> Bugs: MESOS-5078
>     https://issues.apache.org/jira/browse/MESOS-5078
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add documentation for possible task reasons.
> 
> 
> Diffs
> -----
> 
>   docs/home.md ab32838f621de76498262c9dd04e1cf01f8378ca 
>   docs/task-state-reasons.md PRE-CREATION 
>   include/mesos/mesos.proto f31f5bdc2ace2b261885b252e7c01ceb9b76c461 
>   include/mesos/v1/mesos.proto 66386a84bc21989d1c1237e629d5d04662a368fa 
> 
> 
> Diff: https://reviews.apache.org/r/61495/diff/4/
> 
> 
> Testing
> -------
> 
> Built website with site/build.sh and verified it renders ok.
> 
> HTML preview: http://htmlpreview.github.io/?https://github.com/lava/mesos/blob/bennoe/task-reasons/site/publish/documentation/latest/task-state-reasons/index.html
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message