mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Quinn Leng <quinn.leng....@gmail.com>
Subject Re: Review Request 61189: Added authorization for V1 events.
Date Thu, 17 Aug 2017 22:59:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61189/
-----------------------------------------------------------

(Updated Aug. 17, 2017, 10:59 p.m.)


Review request for mesos, Anand Mazumdar, Alexander Rojas, and Greg Mann.


Bugs: MESOS-7785
    https://issues.apache.org/jira/browse/MESOS-7785


Repository: mesos


Description (updated)
-------

Added authorization filtering for the V1 operator events on the
master, the subscriber should only receive events that are
authorized based on their principal and ACLs. Since the authorizer
is called for every event emitted on the stream, the change of
authorization rule will affect events that the subscribers can
receive.


Diffs (updated)
-----

  src/master/http.cpp 959091c8ec03b6ac7bcb5d21b04d2f7d5aff7d54 
  src/master/master.hpp b802fd153a10f6012cea381f153c28cc78cae995 
  src/master/master.cpp 7f38a5e21884546d4b4c866ca5918db779af8f99 
  src/tests/api_tests.cpp 3ab4740bcac29ecb89585da6adb1f563d6fc1f5f 


Diff: https://reviews.apache.org/r/61189/diff/3/

Changes: https://reviews.apache.org/r/61189/diff/2-3/


Testing
-------

make check
GLOG_v=2 ./bin/mesos-tests.sh --gtest_filter="ContentType/MasterAPITest.EventsAuthorizationFiltering*"
--verbose --gtest_repeat=100 --gtest_break_on_failure


Thanks,

Quinn Leng


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message