mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 61704: Added CSI client classes to talk to CSI plugins.
Date Fri, 18 Aug 2017 00:15:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61704/#review183186
-----------------------------------------------------------




include/mesos/csi/csi.hpp
Lines 1 (patched)
<https://reviews.apache.org/r/61704/#comment259201>

    I don't think we need to expose this header yet. Let's have the following layout:
    ```
    src/csi/
       |-- spec.hpp # just include <csi/csi.grpc.pb.h>
       |-- client.hpp
    ```
    
    Let's put the body of this file to `client.hpp`.
    
    Also, I'd suggest we only have one client and embed the runtime (for now).
    ```
    class mesos::csi::Client
    {
    public:
      Client(const string& uri);
    };
    ```


- Jie Yu


On Aug. 16, 2017, 11:08 p.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61704/
> -----------------------------------------------------------
> 
> (Updated Aug. 16, 2017, 11:08 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: mesos-7491
>     https://issues.apache.org/jira/browse/mesos-7491
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added CSI client classes to talk to CSI plugins.
> 
> 
> Diffs
> -----
> 
>   include/mesos/csi/csi.hpp PRE-CREATION 
>   src/csi/csi.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/61704/diff/1/
> 
> 
> Testing
> -------
> 
> Tests described in r/61706.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message