mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot Windows <revi...@mesos.apache.org>
Subject Re: Review Request 61313: Bumped minimum required CMake version to 3.7.0.
Date Fri, 18 Aug 2017 00:24:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61313/#review183188
-----------------------------------------------------------



Patch looks great!

Reviews applied: [61313]

Passed command: support\windows-build.bat

- Mesos Reviewbot Windows


On Aug. 1, 2017, 6:04 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61313/
> -----------------------------------------------------------
> 
> (Updated Aug. 1, 2017, 6:04 p.m.)
> 
> 
> Review request for mesos and Joseph Wu.
> 
> 
> Bugs: MESOS-6350
>     https://issues.apache.org/jira/browse/MESOS-6350
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This is required for the `SOURCE_SUBDIR` functionality of
> `ExternalProject_Add`, which is required to avoid a work-around where we
> re-implement logic the module can do automatically.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 75468abd3641171470a0b8759179dc86496820b5 
> 
> 
> Diff: https://reviews.apache.org/r/61313/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message