mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 61262: Added 'heartbeat' event for the operator API.
Date Fri, 18 Aug 2017 06:35:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61262/#review183163
-----------------------------------------------------------




src/master/master.hpp
Lines 309 (patched)
<https://reviews.apache.org/r/61262/#comment259187>

    Could you also explain the template parameters here? i.e. the first parameter represents
the type of the input message, the second is the type of the event we send on the connection.
    
    Also please explain the purpose of the `delay` parameter to the constructor.



src/master/master.hpp
Lines 310 (patched)
<https://reviews.apache.org/r/61262/#comment259186>

    I think you can get rid of the default template parameter ` = v1::scheduler::Event` here,
since you specify it explicitly in both cases.



src/master/master.hpp
Lines 329-333 (patched)
<https://reviews.apache.org/r/61262/#comment259200>

    I think making `delay` an `Option<Duration>` is more appropriate here. Then this
check could be `if (delay.isSome())`


- Greg Mann


On Aug. 17, 2017, 9:20 p.m., Quinn Leng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61262/
> -----------------------------------------------------------
> 
> (Updated Aug. 17, 2017, 9:20 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Greg Mann.
> 
> 
> Bugs: MESOS-7695
>     https://issues.apache.org/jira/browse/MESOS-7695
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added the 'HEARTBEAT' event for the operator API, modified other
> related test cases to accept heartbeats.
> 
> 
> Diffs
> -----
> 
>   include/mesos/master/master.proto fc5bd894ce55fe8e946d4c5b4b33d3c0505f3c2b 
>   include/mesos/v1/master/master.proto c3fb31de2509adcdec8204f8bbe46b46a31540e8 
>   src/master/http.cpp 959091c8ec03b6ac7bcb5d21b04d2f7d5aff7d54 
>   src/master/master.hpp b802fd153a10f6012cea381f153c28cc78cae995 
>   src/tests/api_tests.cpp 3ab4740bcac29ecb89585da6adb1f563d6fc1f5f 
> 
> 
> Diff: https://reviews.apache.org/r/61262/diff/6/
> 
> 
> Testing
> -------
> 
> make check -j48
> 
> 
> Thanks,
> 
> Quinn Leng
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message