mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jan Schlicht <...@mesosphere.io>
Subject Re: Review Request 61271: Implemented HTTP connection handling for the resource provider driver.
Date Fri, 18 Aug 2017 10:18:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61271/
-----------------------------------------------------------

(Updated Aug. 18, 2017, 12:18 p.m.)


Review request for mesos, Benjamin Bannier and Jie Yu.


Changes
-------

Addressed issues (`Driver::send` now returns a `Future<Nothing>`)


Bugs: MESOS-7469
    https://issues.apache.org/jira/browse/MESOS-7469


Repository: mesos


Description
-------

Similar to the existing HTTP connection handling of schedulers and
executors, the resource provider driver will create two connections
with the resource provider manager, one for streaming events and another
one for sending calls. This connection handling has been generalized as
a 'HttpConnectionProcess' and can be reused in other cases.


Diffs (updated)
-----

  include/mesos/v1/resource_provider.hpp 88b606212ea57fee1c1ea522d2dc7f8124a9adef 
  src/CMakeLists.txt 98ccaf41bf5e7d14164e1c8b6e49268ac865a52c 
  src/Makefile.am 68fff148f3d0c1710305bd9afcba62336d194b55 
  src/resource_provider/detector.hpp PRE-CREATION 
  src/resource_provider/detector.cpp PRE-CREATION 
  src/resource_provider/driver.cpp 6778ec9c863022446f141ee88f70eb563178ea05 
  src/resource_provider/http_connection.hpp PRE-CREATION 
  src/resource_provider/storage/provider.cpp 4c39312be5e4a6d783df3d385a66be6b3dcf8603 


Diff: https://reviews.apache.org/r/61271/diff/6/

Changes: https://reviews.apache.org/r/61271/diff/5-6/


Testing
-------

make check


Thanks,

Jan Schlicht


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message