mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Till Toenshoff <toensh...@me.com>
Subject Re: Review Request 61725: Added secrets docs.
Date Fri, 18 Aug 2017 13:33:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61725/#review183207
-----------------------------------------------------------


Fix it, then Ship it!




Great to see this being documented - thanks so much Kapil!

We may want to be a bit more explicit when it comes to tha lack of Secrets within the docker
containerizer. Couple of possibly entirely incorrect wording suggestions - sorry if they are
BS as I am not a native speaker.


docs/secrets.md
Lines 7 (patched)
<https://reviews.apache.org/r/61725/#comment259221>

    s/now// ?



docs/secrets.md
Lines 9 (patched)
<https://reviews.apache.org/r/61725/#comment259222>

    s/one to specify/specifying ?



docs/secrets.md
Lines 11 (patched)
<https://reviews.apache.org/r/61725/#comment259223>

    Isn't the UCR just a name for the Mesos containerizer using (docker) base images - I am
not sure this won't confuse people. Also note that our docs do not mention "UCR" at all.
    
    Maybe be explicit here; "... and not the docker containerizer"?



docs/secrets.md
Lines 14 (patched)
<https://reviews.apache.org/r/61725/#comment259224>

    Maybe:
    "Secrets can be specified using the following protobuf messages." ?



docs/secrets.md
Lines 41 (patched)
<https://reviews.apache.org/r/61725/#comment259225>

    You are introducing "modules" here which may be a bit confusing. How about mentioning
modules in the high level description already? Something that tells the user that a secret
resolver would be commonly implemented using modules?



docs/secrets.md
Lines 111 (patched)
<https://reviews.apache.org/r/61725/#comment259226>

    Maybe we should be explicit again and tell users that we do NOT mean docker containerizer
here but docker containers handled by the mesos containerizer? By saying only docker containers,
which ones are we not supporting - can we name them here?



docs/secrets.md
Lines 142 (patched)
<https://reviews.apache.org/r/61725/#comment259227>

    s/A default/The default/?
    s/resolved/resolvs/?


- Till Toenshoff


On Aug. 18, 2017, 1:30 a.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61725/
> -----------------------------------------------------------
> 
> (Updated Aug. 18, 2017, 1:30 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Greg Mann, and Till Toenshoff.
> 
> 
> Bugs: MESOS-7418
>     https://issues.apache.org/jira/browse/MESOS-7418
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added secrets docs.
> 
> 
> Diffs
> -----
> 
>   docs/secrets.md PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/61725/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message