mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 61528: Implemented a registrar for resource provider manager state.
Date Fri, 18 Aug 2017 15:46:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61528/
-----------------------------------------------------------

(Updated Aug. 18, 2017, 5:46 p.m.)


Review request for mesos, Jie Yu and Jan Schlicht.


Changes
-------

Followed Jie's implementation suggestion.


Summary (updated)
-----------------

Implemented a registrar for resource provider manager state.


Bugs: MESOS-7555
    https://issues.apache.org/jira/browse/MESOS-7555


Repository: mesos


Description (updated)
-------

This patch adds a registry and registrar interface for resource
provider managers. The registrar interface is modelled after the
master registrar and supports similar operations. Currently a single,
LevelDB-backed registrar is implemented which we plan to use for
resource provider managers in agents.

Current the registry allows to add and remove resource provider IDs.


Diffs (updated)
-----

  src/CMakeLists.txt 98ccaf41bf5e7d14164e1c8b6e49268ac865a52c 
  src/Makefile.am 68fff148f3d0c1710305bd9afcba62336d194b55 
  src/master/registry.proto 362a9fab946e9fb0411df2277f7f3edbadccb61a 
  src/resource_provider/registrar.hpp PRE-CREATION 
  src/resource_provider/registrar.cpp PRE-CREATION 
  src/resource_provider/registry.hpp PRE-CREATION 
  src/resource_provider/registry.proto PRE-CREATION 
  src/tests/resource_provider_manager_tests.cpp 85906ea5e1bb3516ef264de22913ce0a3c9c58c5 


Diff: https://reviews.apache.org/r/61528/diff/2/

Changes: https://reviews.apache.org/r/61528/diff/1-2/


Testing
-------


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message